[2105] Display textual representation of expressions in the Explorer#2115
Open
[2105] Display textual representation of expressions in the Explorer#2115
Conversation
pcdavid
force-pushed
the
pcd/enh/display-expressions
branch
2 times, most recently
from
def8ba9 to
e9d3a92
Compare
AxelRICHARD
reviewed
Apr 8, 2026
| } | ||
|
|
||
| @DisplayName("GIVEN the SysON Explorer, WHEN displaying an Expression item, THEN the item's label shows the textual representation of the expression") | ||
| @Sql(scripts = { ActionTransitionUsagesProjectData.SCRIPT_PATH }, executionPhase = Sql.ExecutionPhase.BEFORE_TEST_METHOD, config = @SqlConfig(transactionMode = SqlConfig.TransactionMode.ISOLATED)) |
Member
There was a problem hiding this comment.
Please use the @GivenSysONServer annotation instead.
Contributor
Author
There was a problem hiding this comment.
Done (also for the others in the class).
| StepVerifier.create(flux) | ||
| .consumeNextWith(initialTreeContentConsumer) | ||
| .thenCancel() | ||
| .verify(Duration.ofSeconds(10_000)); |
Member
There was a problem hiding this comment.
10_000 => 10
Please take car of that please, it happens often in your PRs
Contributor
Author
There was a problem hiding this comment.
Done. I've setup a pre-push git hook to try and catch these in the future.
Bug: #2105 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
pcdavid
force-pushed
the
pcd/enh/display-expressions
branch
from
e9d3a92 to
255713d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: #2105
Signed-off-by: Pierre-Charles David pierre-charles.david@obeo.fr
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Auto review
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc?CHANGELOG.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests